Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only load home page if session uri is blank on new intent. #3545

Merged
merged 1 commit into from Jun 26, 2020
Merged

Only load home page if session uri is blank on new intent. #3545

merged 1 commit into from Jun 26, 2020

Conversation

bluemarvin
Copy link
Contributor

Fixes #3530
Fixes #3543

@bluemarvin bluemarvin added this to the #11 polish milestone Jun 24, 2020
@bluemarvin bluemarvin requested a review from keianhzo June 24, 2020 20:49
@bluemarvin bluemarvin self-assigned this Jun 24, 2020
@bluemarvin
Copy link
Contributor Author

bluemarvin commented Jun 24, 2020 •
edited

Easier STR (must be pico device like G2):

  1. Clear browser data: adb shell pm clear org.mozilla.vrbrowser.internal
  2. Launch FxR
  3. Open a page that isn't the content page.
  4. Press pico button
  5. launch FxR again

Expected:
Previously loaded page is still loaded

Actual with out patch:
The loaded page is briefly visivle but then the content feed gets loaded.

@keianhzo keianhzo merged commit 50e2735 into master Jun 26, 2020
@keianhzo keianhzo deleted the home-on-resume branch June 26, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keianhzo keianhzo keianhzo approved these changes

Assignees

@bluemarvin bluemarvin

Labels
None yet
Projects
None yet
Milestone
#11 polish
2 participants
@bluemarvin @keianhzo