Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Merge localpages.xml and strings.xml #887

Closed
Delphine opened this issue Dec 12, 2018 · 2 comments
Closed

[l10n] Merge localpages.xml and strings.xml #887

Delphine opened this issue Dec 12, 2018 · 2 comments
Assignees
@keianhzo
Milestone
v1.1.1

Comments

@Delphine
Copy link
Collaborator

It would make sense to merge localpages.xml and strings.xml in the same file at this point, like we do for other mobile projects (so, just one file containing all the strings). In fact, there are only two strings left in the localpages.xml file at this point.
Thoughts?
(CC @Pike so he's aware I filed this)
@Pike
Copy link
Contributor

Pike commented Dec 12, 2018

sgtm, we'll want to adjust l10n.toml, if #882 lands before. We'll also want to do that for the localized files.

@cvan cvan added this to the v1.2 milestone Dec 13, 2018
@keianhzo
Copy link
Collaborator

keianhzo commented Dec 14, 2018 •
edited

@Delphine Makes sense, I can't think of any reason why we would need them separated. Will do this after #882 is merged. l10n.toml will need to be updated.

@keianhzo keianhzo self-assigned this Dec 14, 2018
keianhzo added a commit that referenced this issue Dec 14, 2018
@keianhzo
Fixes #887 Merge localpages.xml and strings.xml
591c45f
@keianhzo keianhzo mentioned this issue Dec 14, 2018
Merged
keianhzo added a commit that referenced this issue Dec 17, 2018
@keianhzo
Fixes #887 Merge localpages.xml and strings.xml (#894)
b230f01 
* Fixes #887 Merge localpages.xml and strings.xml

* Added new line to l10n.toml

* add newline at EOF

(nit)

* add newline at EOF

(nit)

* removed extraneous whitespace in Italian "Private Browsing" body string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
None yet
Projects
None yet
Milestone
v1.1.1
Development

No branches or pull requests
4 participants
@Pike @cvan @Delphine @keianhzo