New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ETC2 compressed textures. Add asset compressor tool. #892
Conversation
I need to also convert the controller model images, just forgot they are in different folders, I'll update the PR, but you can start the review already |
77ae356
to
57eb884
Compare
Already converted controller images |
if (VRBrowser::isOverrideEnvPathEnabled()) { | ||
std::string storagePath = VRBrowser::GetStorageAbsolutePath(INJECT_SKYBOX_PATH); | ||
if (std::ifstream(storagePath)) { | ||
skyboxPath = storagePath; | ||
extension = ".jpg"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to either scan or allow user to specify extension. Definitely a followup, I believe there is already an issue on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NoAPI skybox is broken. Will test focus next.
Broken on Focus too. |
Oops, forgot to update VRB, testing again 😔 |
…w assets