Implement dynamic switch between flat and curved display #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
MortimerGoro
force-pushed
the
cylinder_switch
branch
from
17f3e2f
to
561e0eb
Compare
bluemarvin
reviewed
Mar 1, 2019
| @@ -225,14 +225,13 @@ class OculusLayerSurface: public OculusLayerBase<T, U> { | |||
| OculusLayer::BindDelegate bindDelegate; | |||
|
|
|||
| void Init(JNIEnv * aEnv, vrb::RenderContextPtr& aContext) override { | |||
| if (this->swapChain) { | |||
There was a problem hiding this comment.
Does Init() get called multiple times? How can the device have a valid swap chain before calling Init()?
There was a problem hiding this comment.
Init can be called from pause/resume life cycle events, and also just after a layer is created when the activity is already active in VR.
bluemarvin
approved these changes
Mar 1, 2019
|
Resolves #216. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to switch between flat and curved display without a restart.
With Oculus Layers it reuses the swapChain so no surfaces are created during the switch.
With GL geometries it reuses the SurfaceTexture.