Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

移除依赖和增强编译性能和速度 #20

Merged
merged 3 commits into from Sep 1, 2018
Merged

移除依赖和增强编译性能和速度 #20

merged 3 commits into from Sep 1, 2018

Conversation

LuoZijun
Copy link
Collaborator

@LuoZijun LuoZijun commented Aug 29, 2018

  1. 硬编码了字典数据,移除了 phfregex 依赖
  2. 修改了 Cargo.toml 文件

当字典发生变化时,则需要使用 cargo run --bin mk_dict > src/dict.rs 生成新的硬编码字典文件。

@coveralls
Copy link

coveralls commented Aug 29, 2018

Coverage Status

Coverage increased (+0.4%) to 100.0% when pulling 1493a08 on LuoZijun:patch-1 into 4e444b3 on mozillazg:master.

@mozillazg
Copy link
Owner

mozillazg commented Sep 1, 2018

@LuoZijun Thanks for your PR! 👍 速度确实有了很大的提升 👍

P.S. 感觉老版本的 Rust 其实可以不用兼容了(都用了 Rust 谁还在乎兼容旧版 Rust,毕竟官方就经常不兼容旧版 😂 )。

@mozillazg mozillazg changed the base branch from master to develop September 1, 2018 11:58
@mozillazg mozillazg merged commit 375626f into mozillazg:develop Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants