Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve travis ci codecov performance #32

Merged
merged 4 commits into from May 12, 2019

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented May 11, 2019

It may take 30min for the first time to install cargo-update and cargo-travis but will take <2 min afterwards, while now it takes >10min to run every build with tarpaulin

@coveralls
Copy link

Coverage Status

Coverage decreased (-19.3%) to 80.688% when pulling 38bce19 on hanabi1224:travis_cache_tarpaulin into 51cb892 on mozillazg:develop.

@coveralls
Copy link

coveralls commented May 11, 2019

Coverage Status

Coverage decreased (-19.07%) to 80.928% when pulling ef3741e on hanabi1224:travis_cache_tarpaulin into 51cb892 on mozillazg:develop.

@hanabi1224
Copy link
Contributor Author

@mozillazg 原来这个100%cc是不是假的。。。

@mozillazg
Copy link
Owner

mozillazg commented May 11, 2019

@hanabi1224 计算方法不一样(之前排除了 tests/ 和 src/bin/)。看了一下 tarpaulin 计算的覆盖率似乎是有点问题( #31 的测试覆盖率明显不是 100% 却报告是 100%)。 😂

BTW, cargo-travis 会经常装不上(主要是 cargo-update 更新太频繁,经常会安装失败): #21

@hanabi1224
Copy link
Contributor Author

@mozillazg 看起来cargo-update上次更新已经是大半年之前了,另外也可以把 cargo-update那两行注释掉,这样cargo-travis就一直是cache里的固定版本了,有需要的时候手动更新一下?

@mozillazg
Copy link
Owner

mozillazg commented May 12, 2019

@hanabi1224 cache 什么时候失效是不可预知的,倒是没必要依赖 cache 。如果现在用 cargo-update + cargo-travis 稳定的话切回使用 cargo-travis 没问题的,就算偶尔失败也还好,主要是比 tarpaulin 的覆盖率计算错误要更容易接受。

BTW,可以考虑在 cargo-travis 中排除一下 tests/*src/bin/*

@hanabi1224
Copy link
Contributor Author

@mozillazg 加上了,另外这次有cache就非常快了

@hanabi1224
Copy link
Contributor Author

@mozillazg 另外travis的cache失效时间是28天 https://docs.travis-ci.com/user/caching#caches-expiration

@mozillazg mozillazg merged commit 1c75807 into mozillazg:develop May 12, 2019
@hanabi1224 hanabi1224 deleted the travis_cache_tarpaulin branch May 12, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants