Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加一些测试 #42

Merged
merged 6 commits into from Jun 1, 2019
Merged

添加一些测试 #42

merged 6 commits into from Jun 1, 2019

Conversation

upsuper
Copy link
Collaborator

@upsuper upsuper commented Jun 1, 2019

PinyinMulti 添加了一些单元测试,然后添加了一些集成测试。

集成测试的结果目前都是自动生成的,没有仔细校对,主要目的在于捕获regression。

集成测试中用作数据的三个文件分别是

选用这三篇的原因是首先它们在全世界范围内都是公有领域的作品,其次这三篇的拼音使用覆盖了所有韵母。具体检测方法可以参考新加的 coverage-check 这个crate的代码及运行:

cat tests/pinyin/*.txt | cargo run --manifest-path coverage-check/Cargo.toml

@upsuper upsuper requested a review from LuoZijun June 1, 2019 05:28
@coveralls
Copy link

coveralls commented Jun 1, 2019

Coverage Status

Coverage increased (+6.2%) to 100.0% when pulling cfe11da on upsuper:tests into a5f89dd on mozillazg:develop.

@LuoZijun LuoZijun merged commit f8fc11b into mozillazg:develop Jun 1, 2019
@upsuper upsuper deleted the tests branch June 1, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants