Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

当音节以数字声调标记法输出时，字母ü不再被改写为字母v #49 #52

Merged
merged 1 commit into from Jun 12, 2019
Merged

当音节以数字声调标记法输出时，字母ü不再被改写为字母v #49 #52

merged 1 commit into from Jun 12, 2019

Conversation

LuoZijun
Copy link
Collaborator

No description provided.

@LuoZijun LuoZijun changed the base branch from master to develop June 10, 2019 04:46
upsuper
upsuper approved these changes Jun 10, 2019
View reviewed changes
Copy link
Collaborator

@upsuper upsuper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果 @mozillazg 不反对的话我觉得这样也没什么问题。

upsuper
upsuper reviewed Jun 10, 2019
View reviewed changes
build.rs Outdated
('ǘ', 'v', 2),
('ǚ', 'v', 3),
('ǜ', 'v', 4),
('ü', 'ü', 0),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一行可以去掉了。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删。

@coveralls
Copy link

coveralls commented Jun 10, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 996f821 on LuoZijun:patch-7 into 4ed3d43 on mozillazg:develop.

@LuoZijun LuoZijun requested a review from mozillazg June 10, 2019 05:32
mozillazg
mozillazg approved these changes Jun 12, 2019
View reviewed changes
Copy link
Owner

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LuoZijun LuoZijun merged commit 72bc0ac into mozillazg:develop Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upsuper upsuper upsuper approved these changes

@mozillazg mozillazg mozillazg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LuoZijun @coveralls @upsuper @mozillazg