Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change validation type in Polyline #114

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Change validation type in Polyline #114

merged 4 commits into from
Jul 14, 2022

Conversation

normanrz
Copy link
Contributor

This validation also needs to check for number, otherwise it will be in conflict with https://github.com/normanrz/svgwrite/blob/cc938e018b828bdfa84a3911439bb55dd20651b5/svgwrite/shapes.py#L122-L123

@normanrz
Copy link
Contributor Author

The tests are failing, because there are coordinates used as points (ie. with units). From how I read the spec, points need to be composed of numbers only. I'll go ahead and adapt the tests.

@mozman
Copy link
Owner

mozman commented Jul 13, 2022

svgwrite does not support SVG2!

@normanrz
Copy link
Contributor Author

Fair point. I didn't know that.
What would you advise? Shall I change the validations to coordinate everywhere and revert the tests, then?

@mozman
Copy link
Owner

mozman commented Jul 13, 2022

First line of README.rst:

This package is inactive! No new features will be added, there will be no change of behavior, just bugfixes will be merged.

Is this a bug? I don't use this package and I don't want to read the specs again!

@normanrz
Copy link
Contributor Author

Is this a bug?

Yes, it is a bug. I read through the specs, points are list-of-points, which can take pairs of coordinates. I adapted the validations and tests accordingly.

@mozman mozman merged commit f47f68e into mozman:master Jul 14, 2022
@mozman
Copy link
Owner

mozman commented Jul 14, 2022

Thank you!

@normanrz normanrz deleted the patch-1 branch July 14, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants