Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.8 attributes are no longer automatically sorted,
see https://bugs.python.org/issue34160
This was originally reported in #51 but I wasn't able to find the fix.
The
test_pretty_xml
test case is still failing on 3.8 even with this. Looks like runningparseString
andtoprettyxml
now moves the XML Namespace attributes. I don't know if this is intentional or if it can be considered bug in Python. I'd personally probably just move the xmlns attributes in the test to match the expected result but I'm not an XML/SVG expert.Failed test with Python 3.8: