Merge pull request #1397 from glogiotatidis/issue-1396

[Fix #1396] Handle zero impressions gracefully.
mozmeao · Jun 18, 2020 · 052b732 · 052b732
2 parents 34e6e9a + b9a85b6
commit 052b732
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/snippets/base/models.py b/snippets/base/models.py
@@ -2290,14 +2290,20 @@ def calculate_adj_impression(self):
 
     @property
     def adj_block_rate(self):
+        if self.adj_impression == 0:
+            return 'N/A'
         return float(f'{(self.block / self.adj_impression) * 100:.4f}')
 
     @property
     def adj_click_rate(self):
+        if self.adj_impression == 0:
+            return 'N/A'
         return float(f'{(self.click / self.adj_impression) * 100:.4f}')
 
     @property
     def click_rate(self):
+        if self.impression == 0:
+            return 'N/A'
         return float(f'{(self.click / self.impression) * 100:.4f}')