Merge pull request #1380 from glogiotatidis/update-entrypoint-to-snippet

[Issue #1355] Update entrypoint value.
mozmeao · May 18, 2020 · 356b2a5 · 356b2a5
2 parents 1fd05de + 8c73040
commit 356b2a5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/snippets/base/tests/test_util.py b/snippets/base/tests/test_util.py
@@ -97,11 +97,11 @@ def test_multiple_links_with_metrics(self):
                     'action': 'OPEN_ABOUT_PAGE',
                     'args': 'about',
                     'entrypoint_name': 'entryPoint',
-                    'entrypoint_value': 'snippets',
+                    'entrypoint_value': 'snippet',
                 },
                 'link8': {
                     'action': 'OPEN_PREFERENCES_PAGE',
-                    'entrypoint_value': 'snippets',
+                    'entrypoint_value': 'snippet',
                 },
             }
         }
@@ -133,9 +133,9 @@ def test_base(self):
         inputs = [
             ('https://example.com', (None, None, None, None)),
             ('special:menu:foo', ('OPEN_APPLICATIONS_MENU', 'foo', None, None)),
-            ('special:about:login', ('OPEN_ABOUT_PAGE', 'login', 'entryPoint', 'snippets')),
+            ('special:about:login', ('OPEN_ABOUT_PAGE', 'login', 'entryPoint', 'snippet')),
             ('special:highlight:foo', ('HIGHLIGHT_FEATURE', 'foo', None, None)),
-            ('special:preferences', ('OPEN_PREFERENCES_PAGE', None, None, 'snippets')),
+            ('special:preferences', ('OPEN_PREFERENCES_PAGE', None, None, 'snippet')),
             ('special:accounts', ('SHOW_FIREFOX_ACCOUNTS', None, None, None)),
             ('special:monitor', ('ENABLE_FIREFOX_MONITOR', monitor_data, None, None)),
             # This is invalid link but test that the app doesn't choke.

diff --git a/snippets/base/util.py b/snippets/base/util.py
@@ -108,13 +108,13 @@ def convert_special_link(url):
         action = 'OPEN_ABOUT_PAGE'
         args = url.rsplit(':', 1)[1]
         entrypoint_name = 'entryPoint'
-        entrypoint_value = 'snippets'
+        entrypoint_value = 'snippet'
     elif url.startswith('special:highlight:'):
         action = 'HIGHLIGHT_FEATURE'
         args = url.rsplit(':', 1)[1]
     elif url == 'special:preferences':
         action = 'OPEN_PREFERENCES_PAGE'
-        entrypoint_value = 'snippets'
+        entrypoint_value = 'snippet'
     elif url == 'special:accounts':
         action = 'SHOW_FIREFOX_ACCOUNTS'
     elif url == 'special:monitor':