Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #115 from glogiotatidis/django1.4.21
Push Django 1.4.21.
- Loading branch information
36c2c88There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this okay? You downgraded from Django 1.5. I think it'd be better to just use this as an opportunity to upgrade Django to 1.7 or 1.8.
36c2c88There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that I downgraded, I tested locally and on stage before pushing this and looked ok. See also my comment in the commit glogiotatidis@e94ee1f
Do you have reasons to believe that this is not OK?
As far as upgrading to 1.8 I couldn't agree more but not possible in this timeframe.
36c2c88There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None that stood up to your sweet reassurances. 😍
36c2c88There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and obviously there is a edge bug with non-latin chars, that I can't reproduce locally with
ContentFilewhich produced broken bundles. I hot-patched it here b2a7fb4. Let me know if you have any objections.I don't like hot-patching but as I mentioned above upgrading to 1.8 is the way to go but it's not very straight forward and given my limited time due to PTO and conferences in the next months I want to be able to security upgrade fast. I already took a TODO item for 1.8.
36c2c88There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh and btw thanks for always keeping an eye :)
36c2c88There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks fine to me, and it makes sense if you don't have the bandwidth. I started playing around with it myself but I have Pontoon stuff that's more important right now. :(
36c2c88There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks for checking!