This repository has been archived by the owner on Jan 22, 2020. It is now read-only.
Add service detail view and increase test coverage. #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a service detail view as well as more test coverage.
As we do not yet have any service detail data, this PR is both potential architecture and execution. Perhaps we refine architecture in this PR, or ride with/merge this momentum and refine with follow-up PRs as necessary. I'm good either way.
To test:
/local-dev/public/status.yml
. Find servicedms-078f7f5a2f
(it's second in the list for me) and add the key/valuehasDetail: true
./local-dev/public/service-detail/dms-078f7f5a2f/
.index.yml
and paste in the contents from this gist.Assumptions made in this PR:
hasDetail: true
key/value pair to all services instatus.yml
that have service detail information.status.yml
to update YAML data files for all services withhasDetail: true
.I went with requiring
status.yml
to tell the app if a service has detail because the alternative (doing afetch
request for each service to see if a directory/data file exists) seemed pretty sub-optimal. However, if coordinating service detail data with updates tostatus.yml
is a headache, we can reconsider.Note that merging this PR will have no visible impact until a service with
hasDetail: true
exists instatus.yml
.