Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect attribute / Use template-specific version of Lo-dash #4

Merged
merged 2 commits into from Feb 5, 2014
Merged

Conversation

shinnn
Copy link
Contributor

@shinnn shinnn commented Feb 4, 2014

  • At the current version, readonly attribute is mistyped and regarded as spellcheck= (See the screenshot below). So I fixed it as a boolean attribute.

    screenshot 2014-02-05 3 51 19

  • I replaced Underscore.js with the template-specific version of Lo-dash, which is built with lodash include="template" command. (See http://lodash.com/custom-builds for more details about custom build.) It includes only template engine functions and doesn't include unnecessary features.

moznion added a commit that referenced this pull request Feb 5, 2014
Fix incorrect attribute / Use template-specific version of Lo-dash
@moznion moznion merged commit 5ae982f into moznion:master Feb 5, 2014
@moznion
Copy link
Owner

moznion commented Feb 5, 2014

Nice patch!

Thank you.

@moznion
Copy link
Owner

moznion commented Feb 5, 2014

Do I re-build Lo-dash when it is updated?

@shinnn
Copy link
Contributor Author

shinnn commented Feb 5, 2014

Yes. If you want to update it, you should install Node.js and run the following command:

$ [sudo] npm install -g lodash-cli
$ lodash inclide="template" -o <filename>

However, optimizing Lo-Dash is not necessary in this case, because chrome extensions will be installed locally and reducing file size is not important as it is for webapps.
It is mostly subject of personal preference.

If you prefer easier installation and update, you can directly download the full-featured version of Lo-dash.

@moznion
Copy link
Owner

moznion commented Feb 5, 2014

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants