WIP pipeline server, WIP "query" command, working search-text command
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query command doesn't yet fully build pipelines, as that requires additional hookup to the new speculative code for parallel pipelines and junctions, plus new commands for search-text and results compiling. But we can now have test coverage as we iterate on this.
|
Server and VM provisioning succeeded. |
asutherland
added a commit
to asutherland/mozsearch
that referenced
this pull request
May 2, 2022
Now that our indexer checks run with the livegrep server running as started by codesearch.py, we need to replicate the steps to build the python livegrep gRPC bindings. This was missed in local testing because the VM runs both provisioner scripts. This is a fixup to mozsearch#505
asutherland
added a commit
that referenced
this pull request
May 2, 2022
Now that our indexer checks run with the livegrep server running as started by codesearch.py, we need to replicate the steps to build the python livegrep gRPC bindings. This was missed in local testing because the VM runs both provisioner scripts. This is a fixup to #505
|
The test config1.json run on the dev channel revealed we need the python gRPC livegrep build logic from the web-server provisioner, so #506 was created and landing and is provisioning now and I'll re-run the config1 build when it completes. |
|
The config1 dev run completed and seems to operate across multiple repos correctly; there are some rust build warnings that I knew about but have another set of changes to land shortly that should moot the warning and don't have any provisioning or router.py risks (which is why I landed the things with those risks earlier in the day). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This landing include a bunch of progress towards the pipeline server that's still in progress, plus a working implementation of livegrep/codesearch logic via a new
search-textcommand.Because the search-text command includes a new submodule as described at https://bugzilla.mozilla.org/show_bug.cgi?id=1762992#c1 and a bunch of our provisioning logic hardcodes the "master" branch for provisioning, I need to land this to validate
vagrant destroy; vagrant uplocally with the required fidelity. I will also trigger the automated provisioning process (which we know now detects errors after some fixes, woo!) because re-provisioning is absolutely required for tonic-build/prost-build in order for the search-text command to work.The search-text changes also include changes to how we launch codesearch as discussed at https://bugzilla.mozilla.org/show_bug.cgi?id=1762992#c2 through https://bugzilla.mozilla.org/show_bug.cgi?id=1762992#c4 which was the actual plan arrived at. This should not regress router.py behavior but immediately following successful provisioning I will kick off a config1 run against the "dev" channel to sanity-check that I didn't break things ahead of the UTC22 run tonight.