Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Package #25

Closed
bcheidemann opened this issue Feb 3, 2023 · 2 comments 路 Fixed by #26
Closed

NPM Package #25

bcheidemann opened this issue Feb 3, 2023 · 2 comments 路 Fixed by #26

Comments

@bcheidemann
Copy link
Contributor

Hi,

Do you have any interest in distributing this as a WASM / NPM package?

I already did most of the work for this and published it to NPM (@bcheidemann/action-validator) but I'm happy to upstream it into this project 馃檪

Mostly what remains is to merge a PR I raised to Valico for adding WASM support, exposeing errors as a JSValue, and maybe a bit of tidy up.

@bcheidemann
Copy link
Contributor Author

Update, valico PR is merged

@mpalmer
Copy link
Owner

mpalmer commented Feb 3, 2023

Oh, that's neat! I've never dipped my toe into WASM/NPM, so it wasn't on my radar, but I'm not against upstreaming this. Looking at your branch, it'd be nice if the standard test suite could be run in either "native" or "node" mode, and the build/test jobs in the QA workflow modified to ensure that the WASM support stays "fresh". Also, presumably a new job in the release workflow will be needed, to make releases to NPM alongside the native binaries and crate. If you throw up your branch as a PR, we can go through the dance to get it merged in.

@bcheidemann bcheidemann mentioned this issue Feb 4, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants