Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to support intl-tel-input < Number.MAX_SAFE_INTEGER #52

Closed
wants to merge 0 commits into from

Conversation

tlebreton
Copy link
Contributor

Hi :)

This pr allow us to use intl-tel-input 20 Changelog

I needed to update test unit because of this :

Remove defaultToFirstCountry option as that behaviour was jackocnr/intl-tel-input#1525 (comment) and so is not recommended (you can always use initialCountry to set the initial country if you wish to)

I decide to add initialCountry: "ch" because it solve test but don't know if it's correct or not.

Another thinks that changes is the way validNumber works :

By default, calling isValidNumber will now default to mobile-only mode (it will only return true for valid mobile numbers), which means it will be jackocnr/intl-tel-input#1535 - if you don't want this, you can pass false as an argument e.g. isValidNumber(false)

It can be solved with another options 'isMobileVerification' with default to true(like intl-tel-input)

What is your opinion on this subject ?

@tlebreton tlebreton marked this pull request as draft March 18, 2024 16:08
@mpalourdio
Copy link
Owner

Wow, another upstream breaking update, so cool (no).

I suggest we wait for one week or two. The last version (19) has had lots of releases in its short life days. And from what I see, this one has already 4 updates since yersterday :D

@mpalourdio mpalourdio added the dependencies Pull requests that update a dependency file label Mar 18, 2024
@tlebreton
Copy link
Contributor Author

Yeah i fully understand you :D

Please leaves it open and in the begin of april i will be back to you.

@jackocnr
Copy link

jackocnr commented Apr 2, 2024

uh oh, you guys are really going to hate me now 😂

@mpalourdio
Copy link
Owner

mpalourdio commented Apr 2, 2024

@jackocnr @tlebreton we shoud move to "intl-tel-input":">20.0.0" in package.json once and for all, then watch the world burn, WDYT ? 🥲

@mpalourdio mpalourdio changed the title Bump to support intl-tel-input 20 Bump to support intl-tel-input INT_MAX Apr 2, 2024
@mpalourdio
Copy link
Owner

I have update the PR title accordingly 😆

@mpalourdio mpalourdio changed the title Bump to support intl-tel-input INT_MAX Bump to support intl-tel-input < Number.MAX_VALUE Apr 2, 2024
@mpalourdio mpalourdio changed the title Bump to support intl-tel-input < Number.MAX_VALUE Bump to support intl-tel-input < Number.MAX_SAFE_INTEGER Apr 2, 2024
@tlebreton
Copy link
Contributor Author

I will take the time by the end of the week to update the pr according to change made by @jackocnr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants