Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable MPARK_CPP14_CONSTEXPR for MSVC <= 19.15 #49

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Disable MPARK_CPP14_CONSTEXPR for MSVC <= 19.15 #49

merged 1 commit into from
Oct 2, 2018

Commits on Aug 28, 2018

  1. Disable MPARK_CPP14_CONSTEXPR for MSVC <= 19.15 

    The latest Visual Studio 2017 update (version 15.8, MSVC 19.15)
claims to support C++14 constexpr, but it does not. Compiling with
MPARK_CPP14_CONSTEXPR defined emits a litany of errors, e.g.,

    5>c:\...\variant\include\mpark\variant.hpp(386): error C2131: expression did not evaluate to a constant
    5>c:\...\variant\include\mpark\variant.hpp(386): note: failure was caused by a read of a variable outside its lifetime
    5>c:\...\variant\include\mpark\variant.hpp(386): note: see usage of '<traits_0>'
    5>c:\...\variant\include\mpark\variant.hpp(1205): note: see reference to class template instantiation 'mpark::detail::traits<Redacted, Lol>' being compiled
    5>c:\...\variant\include\mpark\variant.hpp(1504): note: see reference to class template instantiation 'mpark::detail::impl<Redacted, Lol>' being compiled

Disable MPARK_CPP14_CONSTEXPR for this and previous versions of MSVC,
with the hope that this problem is addressed in the near future.

Fixes mpark#48
    Matt Kline committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    4e3e7f8 View commit details
    Browse the repository at this point in the history