Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Port ga4 commits to google analytics firebase #22

Merged
merged 1 commit into from Oct 12, 2022
Merged

feat: Port ga4 commits to google analytics firebase #22

merged 1 commit into from Oct 12, 2022

Conversation

peterjenkins
Copy link
Contributor

@peterjenkins peterjenkins commented Oct 5, 2022 •
edited

Summary

  • Port changes from GA4 repo

Testing Plan

  • Verified Xcode project and pod lib lint build successfully

Reference Issue

@peterjenkins peterjenkins self-assigned this Oct 5, 2022
BrandonStalnaker
BrandonStalnaker approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the test fixes

einsteinx2
einsteinx2 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterjenkins peterjenkins merged commit 25f1144 into development Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

Assignees

@peterjenkins peterjenkins

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@peterjenkins @einsteinx2 @BrandonStalnaker