Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Leanplum-iOS-SDK dependency to 6.0+ #20

Closed
wants to merge 2 commits into from
Closed

chore: Update Leanplum-iOS-SDK dependency to 6.0+ #20

wants to merge 2 commits into from

Conversation

via-guy
Copy link

@via-guy via-guy commented Jul 12, 2023

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Upgrade minimum version to fix compilation issues with a lazy var marked with @available in Leanplum-iOS-SDK.

Testing Plan

  • Was this tested locally? If not, explain why.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@via-guy via-guy changed the title Update Leanplum-iOS-SDK dependency to 6.0+ chore: Update Leanplum-iOS-SDK dependency to 6.0+ Jul 12, 2023
@via-guy
Copy link
Author

via-guy commented Aug 25, 2023

@peterjenkins can we please push this along?

@via-guy
Copy link
Author

via-guy commented Sep 21, 2023

@BrandonStalnaker ping?

@via-guy
Copy link
Author

via-guy commented Sep 22, 2023

The CI in my fork is going to repeatedly fail until this is merged. Please help 😅
https://github.com/via-guy/mparticle-apple-integration-leanplum/actions

@BrandonStalnaker
Copy link
Contributor

Sorry about the long delay @via-guy we've assigned this ticket (testing and updating for SPM and Carthage as well) to be done in our current sprint

@BrandonStalnaker
Copy link
Contributor

Closing in favor of #22 that also updates for SPM and Carthage

@via-guy via-guy deleted the chore/Leanplum-iOS-SDK-6.0 branch November 7, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants