Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ERROR ITMS-90205: Invalid Bundle. <app> contains disallowed nested bundles. #8

Merged

Conversation

cameronehrlich
Copy link
Contributor

@cameronehrlich cameronehrlich commented May 22, 2020

Problem:
Currently, Carthage outputs the embedded .frameworks within the /Build/<platform>/mParticle_Optimizely.framework/Frameworks folder. This causes Xcode to embed these frameworks, within the .framework being built. Apple / iTunes Connect disallows frameworks with nested embedded frameworks.

Screen Shot

Screen Shot

Fix: By removing the "Carthage" build phase (Named "ShellScript" for the tvOS target here) Xcode will not create and populate the /Frameworks directory and thus will not cause these .frameworks to be nested in the final product. I checked the mParticle Appsflyer and mParticle Appboy adaptors and they don't have the Carthage build phase either.

@cameronehrlich
Copy link
Contributor Author

Hey @mparticle-teamcity, @BrandonStalnaker, @peterjenkins, what are your thoughts on this?

Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you for your effort. I'll go ahead and merge so it will be in this weeks release

@BrandonStalnaker BrandonStalnaker merged commit 7f91c98 into mparticle-integrations:master May 26, 2020
@cameronehrlich
Copy link
Contributor Author

Awesome, thank you @BrandonStalnaker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants