Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 3 compatibility #5

Merged
merged 4 commits into from
Jul 21, 2016

Conversation

pascaldevink
Copy link
Contributor

@pascaldevink pascaldevink commented Jul 21, 2016

I've shamelessly copied the proposed changes by @kierate (from michelsalib/BCCResqueBundle#127) and @mrardon (from michelsalib/BCCResqueBundle#136) to get the symfony 3 compatibility complete, which fixed #3.
I hope they don't mind me using their work to push this bundle forward.

It should be compatible with both Symfony 2.8 and 3.0|3.1, since the location of the bootstrap.php.cache file is now configurable.

Pascal de Vink added 3 commits July 21, 2016 10:52
@pascaldevink pascaldevink changed the title Remove deprecated 'getRequest' call Symfony 3 compatibility Jul 21, 2016
@mpclarkson
Copy link
Owner

Thanks so much @pascaldevink

@mpclarkson mpclarkson merged commit dd0e295 into mpclarkson:master Jul 21, 2016
@mpclarkson
Copy link
Owner

@pascaldevink let me know if you'd like to be a collaborator on this project - I don't have the bandwidth to maintain it myself.

@pascaldevink
Copy link
Contributor Author

@mpclarkson As my company is heavily relying on resque and the resque bundle, I'm trying to actively participate in any progress that it might have.
That being said, I think most of this bundle is actually pretty stable and it doesn't require a bunch of new features (other than nice-to-haves people have come up with).

So yes, I would like to be a collaborator on this project, but I'd propose even going a step further: how about introducing a special github organisation for this project? That would:

  1. make it a lot easier to ensure the future of the bundle;
  2. make it easier to transfer the bundle to whoever wants to maintain it in the future;
  3. make the namespace agnostic to the maintainer

I've opened a new issue to propose this, so we can discuss it in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symfony3 compatibility
2 participants