fix: plugin_base functions need dcfg as first argument #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thank you @mattgstevens. @alexandergunnarson Would you mind looking at this? You will likely have a better sense of things there since you did the plugin_base refactor IIRC. |
|
Yes, thanks @mattgstevens for that great catch (and @metasoarous for your mention)! Looks good — I must have missed that detail when writing the |
|
@metasoarous This commit fails on master because there's an issue with the gpg key... @mpdairy any ideas? Didn't mean to break master — this was definitely unexpected 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was playing with the latest posh today and came across some errors. This will fix them :)
FWIW when leiningen compiled the project there were warnings mentioning the arity issue.