Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Setup files refactor #283

Merged
merged 4 commits into from
Dec 7, 2021
Merged

🛠 Setup files refactor #283

merged 4 commits into from
Dec 7, 2021

Conversation

k4black
Copy link
Contributor

@k4black k4black commented Dec 7, 2021

The main aim of this PR is to refactor setup.py file to match modern python packaging style and help to avoid some errors in future.

According to packaging.python.org

Static metadata (setup.cfg) should be preferred


The list of changes and explanations:

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #283 (a93b11e) into master (a374301) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files          15       15           
  Lines        1418     1418           
=======================================
  Hits         1318     1318           
  Misses        100      100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a374301...a93b11e. Read the comment docs.

@mpdavis
Copy link
Owner

mpdavis commented Dec 7, 2021

LGTM, thanks @k4black

@mpdavis mpdavis merged commit cfbb868 into mpdavis:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants