Fix Error -3 decompress when using JWE with deflate #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes header error with compression DEFLATE when decrypting payloads generated by Go,Java, and PHP JOSE implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes header error with compression DEFLATE when decrypting payloads generated by Go,Java, and PHP JOSE implementations. I do no know if this effects other implementations, this is a bug our Python applications hit when trying to consume encrypted cookies from our Webapp.
File "/home/me/Projects/Pycharm/TestJWE/venv/lib/python3.11/site-packages/jose/jwe.py", line 187, in decrypt plain_text = _decompress(header.get("zip"), plain_text) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/me/Projects/Pycharm/TestJWE/venv/lib/python3.11/site-packages/jose/jwe.py", line 453, in _decompress decompressed = zlib.decompress(compressed) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ zlib.error: Error -3 while decompressing data: incorrect header check