Limit token size to 250 KB #345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump on this |
smittysmee
reviewed
May 2, 2024
| @@ -76,6 +76,11 @@ def decrypt(jwe_str, key): | |||
| >>> jwe.decrypt(jwe_string, 'asecret128bitkey') | |||
| 'Hello, World!' | |||
| """ | |||
|
|
|||
| # limit the token size to 250 KB | |||
There was a problem hiding this comment.
Suggested change
| # limit the token size to 250 KB | |
| # limit the token size to 250 KB - when this token is processed by the server, it results in significant memory allocation and processing time during decompression. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 6, 2024
https://build.opensuse.org/request/show/1172135 by user dgarcia + anag+factory - Add upstream patches: * CVE-2024-33663.patch, bsc#1223417, gh#mpdavis/python-jose#349 * CVE-2024-33664.patch, bsc#1223422, gh#mpdavis/python-jose#345 * fix-tests-ecdsa-019.patch, gh#mpdavis/python-jose#350
|
Unfortunately the proposed fix just checks that the incoming uncompressed data is no more than than 250KB. I don't know what the maximum size a maliciously crafted 250KB token could expand to, but I imagine it could be significant. Some basic tests suggest that a 250KB token can expand to about 250MB. In addition to sensibly checking the size of the compressed token, I would suggest changing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.