Allow using secret of type "bytes" #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 13 13
Lines 998 998
=======================================
Hits 934 934
Misses 64 64
Continue to review full report at Codecov.
|
|
Anyone? |
beebeeep
added a commit
to beebeeep/cacus
that referenced
this pull request
Jun 25, 2018
|
I'd be interested in merging this if you can add tests. |
Merged
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far library assumes that secrets are strings which leads to certain complications in python3, namely it is impossible to use random binary vectors as secret as python3 string should be valid in terms of specified text encoding. Also constructions like
'keys' in keymay lead to some unexpected behaviour if secret contains substring "keys". This changes makes key parsing logic a bit clearer and allows to use bytes strings secrets.Also I believe that would resolve #74 and #72