Skip to content

Commit

Permalink
Mention other import related changes in changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
@finwe
finwe committed Mar 25, 2019
1 parent 9e8ef43 commit 95dce25
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ mPDF 8.0.0

* Updated FPDI dependency to version 2 (thanks a lot, @JanSlabon)
- removed `SetImportUse` method
- case of `ImportPage` method changed to `importPage`
- case of `ImportPage` method changed to `importPage`, similarly, `setSourceFile` and `useTemplate` were newly introduced.

This comment has been minimized.

Sign in to view

Copy link
@jakejackson1

jakejackson1 Mar 25, 2019

Contributor

It's confusing to say setSourceFile and useTemplate were introduced in this version, when really the case has just been changed.

This comment has been minimized.

Sign in to view

Copy link
@finwe

finwe Mar 25, 2019

Author Member

is it not clear from the similarly? apparently not, will try to rephrase.

This comment has been minimized.

Sign in to view

Copy link
@jakejackson1

jakejackson1 Mar 25, 2019 •
edited
Loading

Contributor

Not when used in conjunction with the phrase newly introduced, no; I understand what it means but it can be construed as ambiguous. Best to be explicit like you've done with the original ImportPage case change.
- signature of `importPage` changed
- returned value of `useTemplate` changed
* Moved QRCode generating code portions to external package _mpdf/qrcode_
- This reduced package size considerably (ca 6MB)
* Fraction sizes without leading zeros allowed for font sizes (#973, thanks @peterdevpl)
Expand Down

0 comments on commit 95dce25

Please sign in to comment.