Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use custom stream wrappers for images #991

Closed
jakejackson1 opened this issue Mar 19, 2019 · 1 comment
Closed

Cannot use custom stream wrappers for images #991

jakejackson1 opened this issue Mar 19, 2019 · 1 comment

Comments

@jakejackson1
Copy link
Contributor

Due to the effect of #950, custom stream wrappers like that registered with the Amazon S3 SDK , which registers s3:// can no longer be used.

Should we consider allowing the supported streams for images to be configured (with a warning about using insecure streams), while defaulting to the current allowed streams?
@finwe
Copy link
Member

finwe commented Mar 19, 2019

If there's a use case and a will, why not?

@jakejackson1 jakejackson1 mentioned this issue Mar 29, 2019
Merged
finwe pushed a commit that referenced this issue Mar 29, 2019
@jakejackson1 @finwe
Allow image stream whitelist to be customised
b69be38 
Resolves #991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@finwe @jakejackson1