Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for page-break-before: avoid; and page-break-after: avoid; for <tr> elements #2004

Merged
merged 11 commits into from Apr 2, 2024

Conversation

carli2
Copy link
Contributor

@carli2 carli2 commented Mar 30, 2024

This code is sponsored by Launix (https://launix.de) and released under GPL 2.0

In order to not get into fork hell, we appreciate a fast release of the feature in the next minor version.

@finwe
Copy link
Member

finwe commented Mar 30, 2024

Thanks for the PR. in order to be incorporated, please add a reasonable test coverage and include a changelog entry.

@carli2
Copy link
Contributor Author

carli2 commented Mar 30, 2024

Thanks to the unit tests I found a copy&paste error, so the change should be fine now.

@finwe
Copy link
Member

finwe commented Apr 2, 2024

Can you also please move the test to a separate class under Issues/? Thanks.

@finwe
Copy link
Member

finwe commented Apr 2, 2024

You should be able to check CS locally easily by just running composer cs.

@carli2
Copy link
Contributor Author

carli2 commented Apr 2, 2024

You should be able to check CS locally easily by just running composer cs.

which issue number shall I use?

@finwe
Copy link
Member

finwe commented Apr 2, 2024

Well, this one, 2004

@finwe finwe merged commit d99a83b into mpdf:development Apr 2, 2024
21 checks passed
@finwe
Copy link
Member

finwe commented Apr 2, 2024

Great, thanks! Can you also prepare a PR to update the supported CSS docs at https://github.com/mpdf/mpdf.github.io/blob/master/css-stylesheets/supported-css.md?

@carli2
Copy link
Contributor Author

carli2 commented Apr 2, 2024

Great, thanks! Can you also prepare a PR to update the supported CSS docs at https://github.com/mpdf/mpdf.github.io/blob/master/css-stylesheets/supported-css.md?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants