Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents PHAR wrapper security issue when loading images #950

Merged
merged 1 commit into from
Jan 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/Image/ImageProcessor.php
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,14 @@ public function setLogger(LoggerInterface $logger)

public function getImage(&$file, $firsttime = true, $allowvector = true, $orig_srcpath = false, $interpolation = false)
{
/**
* Prevents insecure PHP deserialization through phar:// wrapper
* @see https://github.com/mpdf/mpdf/issues/949
*/
if ($this->hasBlacklistedStreamWrapper($file)) {
return $this->imageError($file, $firsttime, 'File contains an invalid stream. Only http://, https://, and file:// streams are valid.');
}

// mPDF 6
// firsttime i.e. whether to add to this->images - use false when calling iteratively
// Image Data passed directly as var:varname
Expand Down Expand Up @@ -1421,5 +1429,27 @@ private function urldecodeParts($url)
return $file . $query;
}

/**
* @param string $filename
* @return bool
* @since 7.1.8
*/
private function hasBlacklistedStreamWrapper($filename)
{
if (strpos($filename, '://') > 0) {
$wrappers = stream_get_wrappers();
foreach ($wrappers as $wrapper) {
if (in_array($wrapper, ['http', 'https', 'file'])) {
continue;
}

if (stripos($filename, $wrapper . '://') === 0) {
return true;
}
}
}

return false;
}

}
94 changes: 94 additions & 0 deletions tests/Mpdf/Image/ImageProcessorTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
<?php

namespace Mpdf\Image;

use Mockery;

use Mpdf\Color\ColorModeConverter;
use Mpdf\Cache;
use Mpdf\RemoteContentFetcher;
use Psr\Log\NullLogger;
use Mpdf\CssManager;
use Mpdf\Color\ColorConverter;
use Mpdf\Language\LanguageToFont;
use Mpdf\Language\ScriptToLanguage;
use Mpdf\Mpdf;
use Mpdf\Otl;
use Mpdf\SizeConverter;

class ImageProcessorTest extends \PHPUnit_Framework_TestCase
{

/**
* @var \Mpdf\Image\ImageProcessor
*/
private $image;

protected function setUp()
{
parent::setUp();

$mpdf = Mockery::mock(Mpdf::class);

$mpdf->shouldIgnoreMissing();

$mpdf->img_dpi = 72;
$mpdf->showImageErrors = true;
$mpdf->PDFAXwarnings = [];

$otl = Mockery::mock(Otl::class);
$cssManager = Mockery::mock(CssManager::class);
$sizeConverter = Mockery::mock(SizeConverter::class);
$colorConverter = Mockery::mock(ColorConverter::class);
$colorModeConverter = Mockery::mock(ColorModeConverter::class);
$cache = Mockery::mock(Cache::class);
$languageToFont = Mockery::mock(LanguageToFont::class);
$scriptToLanguage = Mockery::mock(ScriptToLanguage::class);
$remoteContentFetcher = Mockery::mock(RemoteContentFetcher::class);
$logger = Mockery::mock(NullLogger::class);

$this->image = new ImageProcessor(
$mpdf,
$otl,
$cssManager,
$sizeConverter,
$colorConverter,
$colorModeConverter,
$cache,
$languageToFont,
$scriptToLanguage,
$remoteContentFetcher,
$logger
);
}

/**
* @dataProvider dataProviderStreamBlacklist
*/
public function testStreamBlacklist($filename, $match)
{
try {
$this->image->getImage($filename);
} catch (\Exception $e) {

}

$this->assertRegExp($match, $e->getMessage());
}

public function dataProviderStreamBlacklist()
{
$testData = [];

$wrappers = stream_get_wrappers();
foreach ($wrappers as $wrapper) {
if (in_array($wrapper, ['http', 'https', 'file'])) {
$testData[] = [$wrapper . '://', '/does not exist on this mock object/'];
} else {
$testData[] = [$wrapper . '://', '/File contains an invalid stream./'];
}
}

return $testData;
}
}