Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yapster APIs and streaming processes were leaking - OOMEing over a couple of days (of low traffic on internal dev instances)
investigation showed lots of our
EntityInstance
db records referenced from the global downstream graph metadata inmanifold.stream.graph/handle->downstreams
this was something of a mysterious issue, in that usually stream-related leaks are because some streams are not being closed, and things stop working because streams are not closed and
stream/reduce
s don't terminate - but in this case streams were apparently being closed and correct operation of the system was observedtwo issues were found which are fixed in this PR
deferred/loop
(stream/transform (mapcat identity) <page-stream>)
to concatenate pages from the page-stream on to a record-stream. this appears to be responsible for the leak (replacement of thestream/transform
has fixed the leak)