correct cassandra-driver-dse exclusions #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alia uses the shaded version of the Datastax Java Driver, that suits me because I run a suite of applications that are built on Netty, and sometimes the version that I'm using (current: 4.0.30) differs from that of the driver (current: 4.0.27).
Alia includes com.datastax.cassandra/cassandra-driver-dse which has a dependency on com.datastax.cassandra/cassandra-driver-core (not shaded), originally I excluded netty from dse:
more correctly, that driver-dse should exclude driver-core
Otherwise it's possible (happens in my Jenkins builds) that the non-shaded version of driver-core supersedes shaded on the classpath, but there's no Netty (it's been excluded) and you see an error like:
For more info, see the similar example of excluding driver-core from cassandra-driver-mapper here:
https://github.com/datastax/java-driver/blob/4a17af6af768b77796055dba9ba1e12bd1098b45/features/shaded_jar/README.md