New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: Implement escape-query #43

Merged

mpenet merged 2 commits into mpenet:master from finity-ai:feature-string-escape

Mar 11, 2019

Contributor

axel-angel commented Mar 8, 2019

No description provided.


          utils: Implement escape-query

46477b3

Contributor Author

axel-angel commented Mar 11, 2019

@mpenet what do you think?

Owner

mpenet commented Mar 11, 2019

lgtm.
Just rename the function to escape-query-string, otherwise it can be confusing given the context.


          utils: Rename escape-query{-> string}

ae72bf8

Contributor Author

axel-angel commented Mar 11, 2019

@mpenet thanks, done

mpenet merged commit 55c155f into mpenet:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment