Skip to content

Commit

Permalink
Minor logging improvements to reslock release
Browse files Browse the repository at this point in the history
Reviewed-by: Xuejing Zhao <zxuejing@vmware.com>
Reviewed-by: Jimmy Yih <jyih@vmware.com>
Reviewed-by: Huansong Fu <fuhuansong@gmail.com>
  • Loading branch information
soumyadeep2007 committed Feb 7, 2024
1 parent 5bcfe1b commit 168bcb0
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/backend/utils/resscheduler/resqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -1033,7 +1033,7 @@ ResLockUpdateLimit(LOCK *lock, PROCLOCK *proclock, ResPortalIncrement *increment
{
Assert(limits[0].type == RES_COUNT_LIMIT);
elog(LOG,
"Resource queue id: %d, count limit: %f, portal id: %u\n",
"Resource queue id: %u, count limit: %f, portal id: %u\n",
queue->queueid,
limits[0].current_value,
incrementSet->portalId);
Expand Down Expand Up @@ -1095,7 +1095,7 @@ ResLockUpdateLimit(LOCK *lock, PROCLOCK *proclock, ResPortalIncrement *increment
ResQueue
GetResQueueFromLock(LOCK *lock)
{
Assert(LWLockHeldByMeInMode(ResQueueLock, LW_EXCLUSIVE));
Assert(LWLockHeldByMe(ResQueueLock));

ResQueue queue = ResQueueHashFind(GET_RESOURCE_QUEUEID_FOR_LOCK(lock));

Expand Down Expand Up @@ -1932,7 +1932,7 @@ ResQueueHashFind(Oid queueid)
bool found;
ResQueueData *queue;

Assert(LWLockHeldByMeInMode(ResQueueLock, LW_EXCLUSIVE));
Assert(LWLockHeldByMe(ResQueueLock));

queue = (ResQueueData *)
hash_search(ResQueueHash, (void *) &queueid, HASH_FIND, &found);
Expand Down Expand Up @@ -2676,15 +2676,15 @@ void DumpResQueueLockInfo(LOCALLOCK *locallock)
LOCK *lock = locallock->lock;
ResQueue queue;

LWLockAcquire(ResQueueLock, LW_EXCLUSIVE);
LWLockAcquire(ResQueueLock, LW_SHARED);
/* Get the queue for this lock. */
queue = GetResQueueFromLock(lock);
if (queue != NULL)
{
ResLimit limits = queue->limits;
Assert(limits[0].type == RES_COUNT_LIMIT);
elog(LOG,
"Resource queue id: %d, count limit: %f\n",
"Resource queue id: %u, count limit: %f\n",
queue->queueid,
limits[0].current_value);
}
Expand Down

0 comments on commit 168bcb0

Please sign in to comment.