Skip to content

Commit

Permalink
Remove GPDB_12_MERGE_FIXME in ic_tcp.c (#17154)
Browse files Browse the repository at this point in the history
GPDB_12_MERGE_FIXME in ic_tcp.c:
should use WaitEventSetWait() instead of select() following the routine in ic_udpifc.c

The advantage of using WaitEventSetWait instead of select is that we can monitor
the specific waitevent in the pg_stat_activity view. 

However, we still have many select() calls in current Greenplum codes, it's no need to
replace all of them with WaitEventSet, Because most of them doesn't benefit much
from pg_stat_activity, keep using select() is good and simple enough.
Therefore, we have decided to simply remove this fixme.
  • Loading branch information
zxuejing committed Mar 6, 2024
1 parent 6528c81 commit c35499c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/backend/cdb/motion/ic_tcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -2655,8 +2655,6 @@ RecvTupleChunkFromAnyTCP(ChunkTransportState *transportStates,

}

// GPDB_12_MERGE_FIXME: should use WaitEventSetWait() instead of select()
// follow the routine in ic_udpifc.c
n = select(nfds + 1, (fd_set *) &rset, NULL, NULL, &timeout);
if (n < 0)
{
Expand Down

0 comments on commit c35499c

Please sign in to comment.