Refactor GirlFriday::WorkQueue to use Celluloid #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Runner to execute background jobs Tests are still failing... likely need to be rewritten now that the internals have changed :/
|
I'll give you the commit bit. Please pull this into a separate branch and we can hack on it for a bit and see how well it works. I need to examine Celluloid closer to get a feel for its API and how this might benefit girl_friday. |
|
Cool, pushed to your repo under the "celluloid" branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: this isn't quite ready to pull yet as the tests are still broken. See below.
I took a crack at refactoring girl_friday to use Celluloid rather than the Erlang-in-Ruby actor API. This is a fairly significant change and pretty much entailed completely rewriting GirlFriday::WorkQueue.
A brief synopsis of the changes:
Sorry for submitting a half-baked pull request with broken tests, but I wanted to know first if this sort of change would be accepted and if so, how to proceed with changing the tests to get them passing again.