"Kill" button in retries tab?

[subelsky]

hey @mperham what do you think about a button in the Retries UI that moves jobs into the morgue? Sometimes we get exceptions where I'm working on a fix, and I'd like the job to stop retrying while I fix (maybe because it uses up resources) -- but I'd still like to keep the job around and retry it later. It would be cool to save the dead job in the morgue, then "resurrect" it when I'm ready to try again.

[mperham]

Seems legit to me. Anyone want to PR it?

[seuros]

I will try to do it. I just have to figure out how to send kill to the jobs.

[mperham]

The jobs aren't running. You just need buttons to move them from the 'retries' set to the 'dead' set and back.

[seuros]

I started working in the kill button. So far, i can kill the job and restore it by setting

msg['retry_count'] = Sidekiq::Middleware::Server::RetryJobs::DEFAULT_MAX_RETRY_ATTEMPTS

But i see some flaw with this approach:

• The job can have a non default value for max retry.
• We lose the exact count for retry_count.

I would like to know if there is an API to send the the job to the morgue

i found send_to_morgue in Sidekiq::Middleware::Server::RetryJobs, but it a private method and i wanted to ask if i should public it or just use send().

[mperham]

The job isn't running. It's just sitting in Redis in the retry set and will run some time in the future. You can see it in the Web UI on the Retries tab.

The feature request is a button which can move that retry from the retry set to the dead set. You need to write some code which finds the job in retry set, removes it and pushes it onto the dead set. The current retry options (delete or retry now) are handled here:

https://github.com/mperham/sidekiq/blob/master/lib/sidekiq/web.rb#L163

You could expand the retry_or_delete method to retry_or_delete_or_kill

[seuros]

Ok, understood. I will do it now.