Restarting sidekiq with upstart script

[panmari]

When trying to restart my sidekiq service configured after the example from here https://github.com/mperham/sidekiq/tree/master/examples/upstart, the sidekiq instances are not terminated properly. Only after killing them on my own via

kill $(ps aux | grep 'sidekiq' | awk '{print $2}')

I can successfully restart the job (with sudo service workers restart). I'm using Ubuntu 14.04.3 LTS. Is my configuration wrong or is this the expected behavior?

[mperham]

You need to give us more precise data. Show us your exact .conf file, show us the exact command that is failing.

[panmari]

Here's my worker.conf, more or less a direct copy of the one in the trunk. Same goes for sidekiq.conf.

I get the following behavior:

sudo service workers restart
workers stop/waiting
start: Job failed to start

and when I then run ps aux | grep sidekiq, I see that all instances are still running (and have not restarted).

[mperham]

Let's see your sidekiq.yml.

On Aug 16, 2015, at 05:50, panmari notifications@github.com wrote:

Here's my worker.conf, more or less a direct copy of the one in the trunk.

Same goes for sidekiq.conf.

—
Reply to this email directly or view it on GitHub.

[panmari]

---
:logfile: ./log/sidekiq.log
:concurrency:  5
:queues:
  - [high_priority, 7]
  - [default, 5]
  - [low_priority, 3]

[mperham]

Hmm, can't explain why it's not working then. Looks ok to me.

On Aug 17, 2015, at 03:18, panmari notifications@github.com wrote:

---

:logfile: ./log/sidekiq.log
:concurrency: 5
:queues:

• [high_priority, 7]
• [default, 5]
• [low_priority, 3]
  —
  Reply to this email directly or view it on GitHub.

[panmari]

That's what I thought! Shouldn't an upstart job kill its child processes by default?

[mperham]

Upstart sends TERM to the child process. If the child process forks away (e.g. by daemonizing itself), Upstart can lose track of the process. It's unfortunately complicated.

[panmari]

This issue still persists for me. @mperham any ideas what could be causing this?

[panmari]

Wouldn't the fix descriped here help?

[mperham]

I don't see how that fix is relevant to you. You're only exec'ing the bundle binary, which should work fine. Is your sidekiq.conf still the same?

[panmari]

yes