Fix for uninitialized constant Capistrano::VERSION (NameError)

[yuritomanek]

Hi

This is a fix for the uninitialized constant Capistrano::VERSION (NameError) error I was getting.

Thanks.

[juanibiapina]

It seems to me Capistrano::VERSION is the correct one based on this: https://github.com/capistrano/capistrano/blob/master/lib/capistrano/version.rb

Using Capistrano::Version doesn't work for me.

[mperham]

you're looking at 3.x code. Look at the 2.x branch.

On Mon, Oct 28, 2013 at 8:15 AM, Juan Ibiapina notifications@github.comwrote:

It seems to me Capistrano::VERSION is the correct one based on this:
https://github.com/capistrano/capistrano/blob/master/lib/capistrano/version.rb

Using Capistrano::Version doesn't work for me.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1288#issuecomment-27220430
.

[juanibiapina]

Why?

if defined?(Capistrano::Version) && Gem::Version.new(Capistrano::Version).release >= Gem::Version.new('3.0.0')

If Capistrano::Version is defined, then we're using version 2, not 3. So the second part will never be true.

Capistrano 3 deploy is not working like this. Maybe with my change it worked but broke version 2? I have only tested with capistrano 3, although I don't think it should break.

[mperham]

Oh nuts, you're right. Thanks!

[tisba]

This hasn't been released yet, has it?

[juanibiapina]

I'm using the version from master. I would suggest the deployment code be moved to a different gem, so it can be released and tested separately.

[mperham]

It will be released today.

On Oct 30, 2013, at 4:42, Sebastian Cohnen notifications@github.com wrote:

This hasn't been released yet, has it?

—
Reply to this email directly or view it on GitHub.

[tisba]

@mperham great, thanks!