Sidekiq::Web escape tests #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERB::Util.h doesn't escape apostrophes and slash. Rack::Utils.escape_html is more performant and also escapes all char recommended by OWASP. (rack/rack#27)
|
Nice work! Would you mind removing the rake task? If you don't want to run redis 24/7, you should have your own script to start/stop it. What is the reasoning behind switching from ERB to Rack::Utils? |
|
ok will push the pull request without the rake task again. please look at the commit message for the Rack::Utils change edit: ok pushed |
|
Would update the changelog to give yourself credit? |
|
added myself to Changes.md if thats what you mean by changelog. thanks for merging and your awesome library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidekiq::Web: add tests for escaping job args and error messages.
i noticed that escaping error messages was added recently but doing the same with args was still missing.
all old and new test passed.