Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow absolute pid paths (for Capistrano) #1427

Merged
merged 1 commit into from
Jan 11, 2014
Merged

Allow absolute pid paths (for Capistrano) #1427

merged 1 commit into from
Jan 11, 2014

Conversation

jbourassa
Copy link

The rake tasks forces sidekiq_pid to be relative to Rails.root.

    # must be relative to Rails.root. If this changes, you'll need to manually
    # stop the existing sidekiq process.
    set :sidekiq_pid,             ->{ "tmp/sidekiq.pid" }

This causes an issue when deploying with Capistrano: some tasks are executed before the symlinks are created, thus causing the file test ([-f path_to_pid ]) to fail when it shouldn't.

I will submit a fix shortly.

PS: Awesome gem. 1,000 open source points to the maintainer(s)!

@jbourassa
Copy link
Author

Let me know what you think!

(The PR on my fork was a mistake, please disregard it)

@mperham
Copy link
Collaborator

mperham commented Jan 11, 2014

Seems ok, thanks.

mperham added a commit that referenced this pull request Jan 11, 2014
Allow absolute pid paths (for Capistrano)
@mperham mperham merged commit d07e0e8 into sidekiq:master Jan 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants