Allow absolute pid paths (for Capistrano) #1427
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rake tasks forces
sidekiq_pid
to be relative toRails.root
.This causes an issue when deploying with Capistrano: some tasks are executed before the symlinks are created, thus causing the file test (
[-f path_to_pid ]
) to fail when it shouldn't.I will submit a fix shortly.
PS: Awesome gem. 1,000 open source points to the maintainer(s)!