Remove Sidekiq::Client.default since memoization can break sharding with batches #2505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a fairly subtle bug. Basically, in our code, the only time
Sidekiq::Client.push
gets called is from batch callbacks. I think that the memoization of the pool is causing issues. This is really subtle, I believe it has happened to 1 out of thousands of batches for me, but here's a conceptual idea of how it could happen.Then the batch callback may run on shard 1 if this worker runs the final job, because the batch callbacks use
Sidekiq::Client.push
which uses the memoizeddefault
. This will then fail with "no such batch" because the batch lives on shard 2.Basically,
default
is now dangerous becauseSidekiq::Client
's pool can be changed.