Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parity issue with MFT #38

Closed
mperrin opened this issue Jan 22, 2015 · 3 comments
Closed

Parity issue with MFT #38

mperrin opened this issue Jan 22, 2015 · 3 comments
Labels
bug priority:high

Comments

@mperrin
Copy link
Owner

mperrin commented Jan 22, 2015

Properly speaking this was a poppy issue, not webbpsf.

See mperrin/webbpsf#35
@mperrin
Copy link
Owner Author

mperrin commented Jan 22, 2015

  • Commit 971436b adds test functions that MFT and FFT both preserve parity after forward-then-inverse transforms, which was the original problem that started this.
  • Consider expanding above test function to also compare multiple image planes as well as pupil planes?
  • Should we also test the equivalence of inverse MFT with inverse FFT?

Add test functions for MFT / FFT equivalence:

  • one just testing the base matrixDFT interface based on what we did today,
  • and one testing higher level usage via OpticalSystem and wavefront propagation.

@josePhoenix josePhoenix mentioned this issue Jan 23, 2015
Closed
mperrin added a commit that referenced this issue Jan 23, 2015
@mperrin
Add test for matrixDFT and FFT exact equivalence under proper circums…
a68ad0e 
…tances; See #38
mperrin added a commit that referenced this issue Jan 24, 2015
@mperrin
Add test for MFT and FFT exact equivalence in OpticalSystem ; see #38
78651d0
@mperrin
Copy link
Owner Author

mperrin commented Jan 24, 2015

This is pretty much good to go. There are a couple more tests that could be added for complete thoroughness, but we're reaching the point of diminishing returns.

@mperrin mperrin mentioned this issue Jan 24, 2015
Open
2 tasks
@mperrin
Copy link
Owner Author

mperrin commented Feb 12, 2015

Additional test coverage is now issue #71. This bug is fixed so this issue can be closed.

@mperrin mperrin closed this as completed Feb 12, 2015
douglase pushed a commit to douglase/poppy that referenced this issue May 1, 2015
@embray
Merge pull request mperrin#38 from mwcraig/patch-1
0811108 
Replace distribute_setup.py with ez_setup.py
This was referenced Aug 23, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority:high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mperrin