Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIRCam _validate_config will need to be updated to handle sources given as weights #31

Closed
josePhoenix opened this issue Dec 16, 2014 · 3 comments
Assignees
Milestone

Comments

@josePhoenix
Copy link
Collaborator

No description provided.

@josePhoenix josePhoenix modified the milestone: 0.3 Jan 15, 2015
@mperrin
Copy link
Owner

mperrin commented Jan 21, 2015

Description: Currently this uses the filter name string to determine whether to set the pixel scale to the NIRCam short or NIRCam long scales. Assumes the filter is a string in HST/JWST style 'F200W', 'F470N', etc.

The suggestion was that if the user decides to specify the wavelengths and weights manually, then this filter name approach will not work, and will need to be updated.

One minor difficulty I see is that right now _validate_config is called from inside _getOpticalSystem, and doesn't have access to the source information, which is dealt with in _getWeights. So some refactoring would be needed, and we should try to think about how to minimize how convoluted this code gets.

I think this only makes sense to do after you merge in your Filter-as-an-object code, which I recall you telling me about a while ago. But I'm not sure if that is ready to go in 0.3?

@josePhoenix josePhoenix self-assigned this Jan 23, 2015
@josePhoenix
Copy link
Collaborator Author

I think it might make sense to move the call to _validate_config into Instrument.calcPSF. At the moment it only serves to solve our immediate problem, but thinking ahead to specifying a field position (for field dependence support) we'll probably want to validate the config with info on the aperture and position. I'm imagining that the aperture will be set as an attribute or property on Instrument, and position will be passed in to calcPSF. For that case, then, we will again want to pass _validate_config something only calcPSF knows about.

@josePhoenix
Copy link
Collaborator Author

Fixed by #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants