-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full API definition for lua-nginx-module #118
Conversation
This is based on the v 0.10.10 API. For clarity the API definition has been moved to a separate file.
Thanks, I'll look through this more closely this week and then merge. Do you know how often are these fields removed in new lua-nginx versions? If only new fields are added, then this new standard remains the superset of all fields in all versions and all is good, but if in some version there were more fields, code against that version will have false positives when checked with this standard. |
The updates are usually very conservative, from what I can remember since a few years there were very few breaking changes, and none of them removed functions or constants. So I don't think there is any problem on this side. The only issue that I can see is that we will have to update the API definition whenever new functions will be added in future versions. |
Some comments after looking through API docs in https://github.com/openresty/lua-nginx-module
(Just in case, when adding commits please don't squash them with already pushed ones so that it's obvious what's updated.) |
Thanks for pointing this out, I somehow missed these two. Pushed this as a separate commit.
No, they are regular Lua module, and don't have any global side effect.
Actually only Do you think it would make sense to put some helper functions in a separate module? The |
Yes, I'll do that. Merging, new version will be released this week. Thanks! |
Great, thanks a lot! |
This is based on the v 0.10.10 API. For clarity the API definition
has been moved to a separate file.