Add option not to override existing env variables #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeteuil
force-pushed
the
dont-override-env-vars-option
branch
from
97d8388
to
a111e50
Compare
The reason the default behavior of this plugin is what it is, is because it has origins during the time when there were a lot of users migrating away from [Pipenv](https://github.com/pypa/pipenv), many switching to Poetry. [Pipenv had built-in `.env` loading](https://pipenv.pypa.io/en/latest/shell/#automatic-loading-of-env) which [did override by default (and still does)](https://github.com/pypa/pipenv/blob/98bdb5f8b2f08a435a825915d7d7d215a7aaec19/pipenv/utils/environment.py#L37). In order to support the many people coming from `pipenv` the goal was to make the fewest changes from that toolset possible in regards to `.env` loading. That is also why there are other some [analogous environment variables between this project and `pipenv` with a section about them in the README](https://github.com/mpeteuil/poetry-dotenv-plugin#coming-from-pipenv). If you're coming from vanilla `python-dotenv` then this is unexpected. That needs to be reconciled with the expectations of anyone coming from `pipenv`. Here we add a system environment variable—`POETRY_DOTENV_DONT_OVERRIDE`. I think it should solve most cases. This is because most users who want it to [behave like `python-dotenv`'s defaults](https://github.com/theskumar/python-dotenv#getting-started) probably want that everywhere and the same for anyone who wants it to behave like `pipenv`.
mpeteuil
force-pushed
the
dont-override-env-vars-option
branch
from
a111e50
to
b3b09a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason the default behavior of this plugin is to override existing environment variables is because it has origins during the time when there were a lot of users migrating away from Pipenv, many switching to Poetry. Pipenv had built-in
.envloading which did override by default (and still does). In order to support the many people coming frompipenvthe goal was to make the fewest changes from that toolset possible in regards to.envloading. That is also why there are other some analogous environment variables between this project andpipenvwith a section about them in the README.If you're coming from vanilla
python-dotenvthen this is unexpected. That needs to be reconciled with the expectations of anyone coming frompipenv. Here we add a system environment variable—POETRY_DOTENV_DONT_OVERRIDE. I think it should solve most cases. This is because most users who want it to behave likepython-dotenv's defaults probably want that everywhere and the same for anyone who wants it to behave likepipenv.This resolves #14