Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme breaks Date fields in node form #7

Open
fixed opened this issue Nov 13, 2012 · 5 comments
Open

Theme breaks Date fields in node form #7

fixed opened this issue Nov 13, 2012 · 5 comments

Comments

@fixed
Copy link

fixed commented Nov 13, 2012

Date fields with jQueryUI calendar popups are just hidden. No way to edit them.
Works with Garland, though.

@mpezzi
Copy link
Owner

mpezzi commented Nov 13, 2012

Maybe an issue with jQuery versions? I know Bootstrap requires jQuery 1.7+ and Drupal ships with jQuery UI 1.8.11. I have encountered some bugs when using jQuery Update 7.x-2.x-dev on the admin side.

I'm not really using Bootstrap as a backend admin theme, but any help in this area is greatly appreciated!

@fixed
Copy link
Author

fixed commented Nov 15, 2012

Well, I don't get any errors anymore, as I fixed the the most template functions in your theme. However, even though I am running with jQ 1.7.1, it seems to have some quirks (no JS errors either, though) .. I will investigate it further ..

@fixed
Copy link
Author

fixed commented Nov 15, 2012

It seems that some modules (especially the ones using JS) expect the form element DOM structure to be as defined by the Drupal theming system whereas the Bootstrap themes wraps elements in further div's (.control-group & .controls). Is this really needed or can't we just alter the ones already created ?

@mpezzi
Copy link
Owner

mpezzi commented Nov 15, 2012

Interesting ... is the script looking to attach itself using an id or class? To get bootstrap's forms themed we need to wrap them with these extra elements. Maybe we can merge ids and classes? I'll have to look into it.

Can you provide the module versions you're using?

@fixed
Copy link
Author

fixed commented Nov 19, 2012

I've looked into the bootstrap docs and there are only a few places where these extra elements are needed (horizontal forms and error reporting I believe).. Either way, my Date fields seem to work now. Must have been something with the cache ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants