Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for content:encoded support for Podcast #94

Open
rock3r opened this issue May 20, 2021 · 5 comments
Open

Add support for content:encoded support for Podcast #94

rock3r opened this issue May 20, 2021 · 5 comments
Assignees
Labels
API breaking enhancement New feature or request
Milestone

Comments

@rock3r
Copy link
Collaborator

rock3r commented May 20, 2021

We are modeling the content:encoded for the <item> nodes, but not for the <channel> nodes. That's not great, because many podcasts use it (e.g., src/test/resources/xml/real-life-feeds/reply-all.xml). We should add a PodcastContent.

@rock3r rock3r added the enhancement New feature or request label May 20, 2021
@rock3r rock3r added this to the 1.1.0 milestone May 20, 2021
@rock3r rock3r self-assigned this May 20, 2021
@rock3r
Copy link
Collaborator Author

rock3r commented May 21, 2021

I have done this but it is a breaking change both in terms of source and binary compatibility. I can create a 2.0.0 branch once #95 is merged, and we can consider shipping 1.1.0 since it has a meaty set of changes as it is already. What do you think @mpgirro?

@rock3r rock3r added this to To do in Library Development May 21, 2021
@mpgirro
Copy link
Owner

mpgirro commented May 22, 2021

I'm fine with shipping 1.1.0. I've got about half of #76 done, but won't be able to finish it in the near future. Just something for 1.2.0 then :)

@rock3r rock3r removed this from the 1.1.0 milestone May 23, 2021
@rock3r
Copy link
Collaborator Author

rock3r commented May 23, 2021

Makes sense. I'll tag and release 1.1.0, and create 1.2.0 and 2.0.0 milestones.

@rock3r rock3r added this to the 2.0.0 milestone May 23, 2021
@mpgirro
Copy link
Owner

mpgirro commented May 25, 2021

👍

@rock3r
Copy link
Collaborator Author

rock3r commented May 25, 2021

I've discovered a pretty severe bug with the List<...>.asBuilders() implementations, I'm working on a fix and will release 1.1 after that's shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API breaking enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants